search

PagerDuty / go-pagerduty

go client library for PagerDuty v2 API
https://v2.developer.pagerduty.com/docs/rest-api
Apache License 2.0
287 stars 241 forks source link

Fix for `go install` #436

Closed mjlshen closed 1 year ago

mjlshen commented 2 years ago

By moving the contents of command into a command/pd subdirectory, go install can now be used to install a binary.

I updated the README to demonstrate an example for latest, since the instructions won't work for v1.5.0, but maybe when the next version is released the example in the README can be pinned to a version?

Fixes #435

mjlshen commented 2 years ago

@theckman Not sure if you have cycles to review this - totally ok if you don't, but if I should ping someone else please let me know, thanks!

mjlshen commented 2 years ago

Tagging @stmcallister - noticed that you've reviewed other PRs

theckman commented 2 years ago

I think we need to figure out what we want to do with the command line tool. There's been a discussion in the past about this being removed from the project. I wonder if it makes sense to ask a PagerDuty employee to create a new repo, and migrate the code there so that it's go-getable.

@stmcallister would that be something we could make happen?

sodabrew commented 1 year ago

Subscribe. watching for Go 1.19 compatibility to go install... the cli.