PagerDuty / go-pagerduty

go client library for PagerDuty v2 API
https://v2.developer.pagerduty.com/docs/rest-api
Apache License 2.0
287 stars 241 forks source link

Ars/webhook updates #437

Closed arussellsaw closed 2 years ago

arussellsaw commented 2 years ago

having non-pointer non-omitempty fields meant we were sending invalid params for updates, this means we only send the fields we set.

arussellsaw commented 2 years ago

Oh wow I didn't realise I raised this 🙈 I think I misclicked when trying to PR against our internal fork. This would be nice to have upstream anyway, but sorry for accidentally asking for your review when it wasn't as polished as it should be. I'll see if I can find some time this week to tidy up