search

PagerDuty / pdpyras

Low-level PagerDuty REST/Events API client for Python
MIT License
129 stars 29 forks source link

iter_all still includes the attribute keyword arg when short circuiting to iter_cursor #114

Closed Deconstrained closed 11 months ago

Deconstrained commented 1 year ago

This could lead to an error when using iter_all or any of its wrappers (i.e. list_all) on an endpoint that supports cursor-based pagination.

It's a very young use case but it is sure to come up and cause issues for users eventually.

See:

https://github.com/PagerDuty/pdpyras/blob/main/pdpyras.py#L1740