search

PagerDuty / pdpyras

Low-level PagerDuty REST/Events API client for Python
MIT License
130 stars 30 forks source link

V4.2 idempotent update and better error handling #35

Closed Deconstrained closed 4 years ago

Deconstrained commented 4 years ago

Just two more little improvements, including one that I should have made years ago.

Deconstrained commented 4 years ago

Ruh-roh, regression due to type hints being strictly a Python 3.5-and-later thing.

I really don't want to dumb down this PR to get it to pass in Python 2.7. Instead I'm going to wait until we see enough of the userbase migrate away from Python 2.7 to officially end support for 2.7. Then, I'll roll this out as v5.0 with an appropriate announcement. That should reduce the amount of scrambling to migrate away from 2.7 that would result if I were to release a new version that ends support for 2.7 right now.

Currently 3.1% of all API calls made with pdpyras were made with Python 2.7 (of a random sample of API calls over the past 24 hours), not including events API traffic (REST API only) but it still represents a lot of different organizations.