PagerDuty / terraform-provider-pagerduty

Terraform PagerDuty provider
https://www.terraform.io/docs/providers/pagerduty/
Mozilla Public License 2.0
206 stars 210 forks source link

Disable warning "Warning: Modifying the event_orchestration property of the 'pagerduty_event_orchestration_integration' resource will cause all future events sent with this integration's routing key to be evaluated against the new Event Orchestration." #839

Closed red8888 closed 6 months ago

red8888 commented 6 months ago

Terraform Version

Terraform v1.1.4 on darwin_arm64

Affected Resource(s)

pagerduty_event_orchestration_integration

Terraform Configuration Files

resource "pagerduty_event_orchestration_integration" "integration" {
  for_each            = tomap({ for i in var.event_orcastrations : i.event_orcastration_name => i })
  event_orchestration = pagerduty_event_orchestration.event_orchestration[each.value.event_orcastration_name].id
  label = "${each.value.event_orcastration_name}"
}

Do I need to see this every time I plan?

Warning: Modifying the event_orchestration property of the 'pagerduty_event_orchestration_integration' resource will cause all future events sent with this integration's routing key to be evaluated against the new Event Orchestration.

│   with module.test.pagerduty_event_orchestration_integration.integration["some key"],
│   on ../pd.tf line 10, in resource "pagerduty_event_orchestration_integration" "integration":
│   10:   event_orchestration = pagerduty_event_orchestration.event_orchestration[each.value.event_orcastration_name].id

Am I doing something wrong or bad? Can I tell PD I know what I'm doing? This warning does a lot to obfuscate actual output and I'd like to turn it off (without disabling ALL tf warnings). Unless there is something wrong I'm doing here.

alenapan commented 6 months ago

Hi @red8888, we have prioritized the work to remove the warning because, like you mentioned, it's not actionable and creates unnecessary noise in the output. It was initially added to emphasize the fact that modifying the event_orchestration attribute will change how your future events for this routing key are evaluated, because the Integration will be migrated to a new Event Orchestration. But we can definitely see that getting the warning every time you run terraform plan is more of an annoyance than a helpful message.