Migrate pack #2 of datasources and resources to terraform plugin framework

[cjgajard]

Includes migration to terraform plugin framework for:

• pagerduty_service_dependency
• data.pagerduty_service_integration
• data.pagerduty_service
• pagerduty_addon

Fix variable and property names, and other suggestions in ./pagerdutyplugin from linters golangci-lint and revive.

Acceptance tests execution results after Terraform objects migration...

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyBusinessServiceDependency -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccPagerDutyBusinessServiceDependency_Basic
--- PASS: TestAccPagerDutyBusinessServiceDependency_Basic (28.53s)
=== RUN   TestAccPagerDutyBusinessServiceDependency_Parallel
--- PASS: TestAccPagerDutyBusinessServiceDependency_Parallel (50.23s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     80.017s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       0.975s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.529s [no tests to run]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccDataSourcePagerDutyIntegration -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccDataSourcePagerDutyIntegration_Basic
--- PASS: TestAccDataSourcePagerDutyIntegration_Basic (18.58s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     19.118s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       0.745s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.863s [no tests to run]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccDataSourcePagerDutyService -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccDataSourcePagerDutyService_Basic
--- PASS: TestAccDataSourcePagerDutyService_Basic (15.15s)
=== RUN   TestAccDataSourcePagerDutyService_HasNoTeam
--- PASS: TestAccDataSourcePagerDutyService_HasNoTeam (14.92s)
=== RUN   TestAccDataSourcePagerDutyService_HasOneTeam
--- PASS: TestAccDataSourcePagerDutyService_HasOneTeam (14.15s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     44.886s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       0.412s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.746s [no tests to run]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyAddon -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccPagerDutyAddon_Basic
--- PASS: TestAccPagerDutyAddon_Basic (7.14s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     7.664s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       0.736s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.852s [no tests to run]