search

PagerDuty / terraform-provider-pagerduty

Terraform PagerDuty provider
https://www.terraform.io/docs/providers/pagerduty/
Mozilla Public License 2.0
204 stars 208 forks source link

Invalid Go Module Name #891

Open iwahbe opened 2 weeks ago

iwahbe commented 2 weeks ago

Go's module documentation suggests that module paths should be of the form

github.com/PagerDuty/terraform-provider-pagerduty/v3
^          ^         ^                           ^
VCS URL    ORG       REPO                        VERSION

Currently, it is

https://github.com/PagerDuty/terraform-provider-pagerduty/blob/7bdd60f87b10ea4fdc7907243816169b78eee44d/go.mod#L1

Expected behavior

The module name (in go.mod) is github.com/PagerDuty/terraform-provider-pagerduty/v3

Additional context

I work at Pulumi and maintain pulumi-pagerduty (which is based off of terraform-provider-pagerduty) for shared customers. It would make our lives easier if you used Go's convention for module paths.

If your willing to take it, I'd be happy to open a PR implementing this change.