search

PagerNation / Escalator-API

MIT License
3 stars 0 forks source link

Add ticket model #4

Closed kwm4385 closed 7 years ago

kwm4385 commented 7 years ago

closes https://github.com/PagerNation/PagerNation/issues/48

jarrydlee commented 7 years ago

Is this still WIP?

kwm4385 commented 7 years ago

Nope good to go.

kalebingerick commented 7 years ago

Before this is merged, this should be rebased. There's no need for two separate commits.

kwm4385 commented 7 years ago

Discussed changes have been made @jarrydlee @kalebdavis

jarrydlee commented 7 years ago

Apart from those comments, LGTM

kwm4385 commented 7 years ago

Not sure how to chunk this since the code volume is relatively small. I think squashing it into one commit would be fine.

kalebingerick commented 7 years ago

WRT the commits, that's fine by me. I chunked mine into model code and test code, but feel free to do whatever you think is best. I just don't want 8 commits