search

PaintNinja / Presence-Footsteps-Forge

An overly complicated footstep sound enhancement mod for Minecraft
presencefootsteps.ha3.eu
MIT License
5 stars 8 forks source link

Error rendering overlay 'Text Columns' loop #3

Closed MattB70 closed 2 years ago

MattB70 commented 2 years ago

When loading resources (trigger easily be changing a resource pack), Presence Footsteps can loop forever on this error:

Cannot invoke "eu.ha3.presencefootsteps.PFDebugHud.render(net.minecraft.world.phys.HitResult, net.minecraft.world.phys.HitResult, java.util.List)" because the return value of "eu.ha3.presencefootsteps.PresenceFootsteps.getDebugHud()" is null

Full log (very long as it loops until crashing from running out of memory): https://gist.github.com/MattB70/071842981ff0f582355bfface6b5d4d0

It looks like getDebugHud() is missing, hidden, or unfinished. Adding a null checker will be an easy patch.

TreyRuffy commented 2 years ago

Yes, getDebugHud() needs a null checker in order to instantiate PFDebugHud. It was removed while porting over from fabric.

PaintNinja commented 2 years ago

Thanks for your report. I've fixed this in 1.18.2-1.5.0-beta2 by removing the mixin referencing the debug hud entirely rather than adding overhead with a null check.

https://www.curseforge.com/minecraft/mc-mods/presence-footsteps-forge