search

PaintNinja / Presence-Footsteps-Forge

An overly complicated footstep sound enhancement mod for Minecraft
presencefootsteps.ha3.eu
MIT License
5 stars 8 forks source link

[MC 1.20.1] Revert restricted forge version to unblock compatibility with NeoForge (issue #45) #49

Open Lothrazar opened 1 month ago

Lothrazar commented 1 month ago

The internal code of the mod is already compatible between forge and neoforge.. at least in MC1.20.1 specifically, not sure about new mc versions.

Therefore, if we undo the restriction in the META mods toml file and a few other tweaks it runs fine in neoforge.

(the other commits in the branch are me making a local build and then reverting some changes. and setting the version in properties file)

And there is a build here for testing https://github.com/Lothrazar/Presence-Footsteps-Forge/releases/tag/1.20.1-1.9.1-neoforge-compatible

Lothrazar commented 1 month ago

cant screenshot sounds but this is a screenshot after the mods load. Sounds fine in world as well screenshot

CapoFantasma97 commented 2 days ago

Maybe you could publish your own NeoForge fork, it seems that PaintNinja hasn't been touching this project in a long time and will probably never merge this pull request.