PaintWithBob / paint-with-bob

Bob Ross Painting IO game development.
https://paintwithbob.com/
Apache License 2.0
4 stars 0 forks source link

Lobby Bleeding, and Incorrect Guest Behavior #131

Closed torch2424 closed 6 years ago

torch2424 commented 6 years ago

closes #127

This fixes a weird error where creating multiple lobbys would bleed into one another and things like that. Was because of a deep clone error of the room object schema. Opened 6 different browsers to manually test these cases:

  1. Guests could not get placed into private rooms.
  2. Guests cannot get placed in rooms with 4 users.
  3. Creating a new Lobby won't bleed into another
  4. Guests cannot be placed in private rooms

Screenshot of extreme testing

screen shot 2018-04-11 at 5 11 42 pm screen shot 2018-04-11 at 5 12 01 pm