search

Painted-Fox / jekyll-category-pagination

This jekyll plugin enables separate categories to be paginated.
14 stars 5 forks source link

Why deprecated? #5

Open mhulse opened 10 years ago

mhulse commented 10 years ago

I'm new to Jekyll, but why do you say:

It appears that Jekyll v1.0 already has this feature and this plugin is deprecated.

When the Jekyll docs say:

Pagination does not support tags or categories

Pagination pages through every post in the posts variable regardless of variables defined in the YAML Front Matter of each. It does not currently allow paging over groups of posts linked by a common tag or category.

Maybe I don't understand how this plugin is supposed to work?

I'd like to paginate posts based on category. Isn't this what your plugin does (and, based on note above, Jekyll's default paginator doesn't do)?

Thanks!

Painted-Fox commented 10 years ago

I didn't realize that the Jekyll docs say that. I tested plain Jekyll and created a category using a folder, and Jekyll appeared to paginate based on that when I tried it. I'll take a closer look at this soon.

mhulse commented 10 years ago

Hi @Painted-Fox! Thanks for the quick reply!

I didn't realize that the Jekyll docs say that.

Ahhh. Yah, I'm sure it had been added since you last looked maybe? Seems like the Jekyll team is adding a lot of new stuff (including documentation changes) on a regular basis.

I tested plain Jekyll and created a category using a folder, and Jekyll appeared to paginate based on that when I tried it.

Oh, nice! Sorry, I should have tested myself. I guess the "deprecated" note threw me off.

I'll take a closer look at this soon.

Wow, thanks! And no rush. I did not mean to raise any alarm. Though, based on the current Jekyll docs, it does look like your plugin still has a place in the world of Jekyll. :+1:

Thanks for sharing your awesome code!