Paladiex / Palbot

A Summoners War all purpose bot!
10 stars 12 forks source link

getAppUsableScreenSize() vs getRealScreenSize() #8

Open namack75 opened 6 years ago

namack75 commented 6 years ago

would it be possible to use getRealScreenSize() instead of getAppUsableScreenSize()?

on the Pixel phone getAppUsableScreenSize returns the (screensize - navbarsize). The NavBar appears when the Ankulua dialog shows, which distorts the resolution.

Locally I've made the change, and it works, just wondering if its an option for you moving forward.

digaomatias commented 6 years ago

We just need to check this won't break on other devices. But it should work fine. I'll check it and include it.

On Fri, Jul 6, 2018, 16:39 Nolan Mack notifications@github.com wrote:

would it be possible to use getRealScreenSize() instead of getAppUsableScreenSize()?

on the Pixel2 getAppUsableScreenSize returns the (screensize - navbarsize). The NavBar appears when the Ankulua dialog shows, which distorts the resolution.

Locally I've made the change, and it works, just wondering if its an option for you moving forward.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Paladiex/Palbot/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKc31yId1rA-DlxOm9lfr0EnCeK6xqDks5uD7zhgaJpZM4VF8B1 .