Closed akashpaladin closed 4 months ago
The recent changes enhance the RDSDBManager
to support updatable columns during record insertion, improving database operations. Additionally, AssetGroupManager
and TargetTypeService
were updated to accommodate these changes, with TargetTypeService
also undergoing significant refactoring to streamline target type configurations.
File Path | Change Summary |
---|---|
.../RDSDBManager.java |
Enhanced insertRecord to handle duplicate key updates using updatableColumns parameter. |
.../AssetGroupManager.java |
Modified createDefaultAssetGroup to pass null for the new updatableColumns parameter in insertRecord . |
.../TargetTypeService.java |
Refactored configureNewTargetType method, removed typesInDB logic, and updated createNewTargetType to use Collections.singletonList("displayName") . |
sequenceDiagram
participant Client
participant AssetGroupManager
participant RDSDBManager
participant Database
Client->>AssetGroupManager: createDefaultAssetGroup()
AssetGroupManager->>RDSDBManager: insertRecord(..., null)
RDSDBManager->>Database: INSERT INTO ... ON DUPLICATE KEY UPDATE ...
Note over Client,Database: Handling duplicate key updates
sequenceDiagram
participant Client
participant TargetTypeService
participant RDSDBManager
participant Database
Client->>TargetTypeService: configureNewTargetType()
TargetTypeService->>RDSDBManager: insertRecord(..., Collections.singletonList("displayName"))
RDSDBManager->>Database: INSERT INTO ... ON DUPLICATE KEY UPDATE displayName
Note over Client,Database: Streamlined target type configuration
In the realm of code so bright, New features come to light, With columns updatable, records stay right, Asset groups and targets take flight, Database dances in delight, As Pacman’s shipper reaches new height! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Description
PLG-572
Before running shipper
After running Shipper
Problem
Solution
Fixes # (issue if any)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Other Information:
List any documentation updates that are needed for the Wiki
Summary by CodeRabbit
New Features
Improvements
Refactor