go-jay commented 1 month ago

Description

https://paladincloud.atlassian.net/browse/UIUX-707

Solution:

Remove the box icon in the empty state message in associated policies and policy violation summary widget
Change empty state message in the associated policies widget to “There are no active policies for this asset type“
Change empty state message in the policy violation summary to “There are no violations for this asset“

Extra:

In the violations by severity widget on the dashboard screen, we have removed the call-to-action (CTA) during the empty state.

Type of change

[x] New feature (non-breaking change which adds functionality)

Does this change include any breaking change? If Yes, please elaborate.

No

How Has This Been Tested?

[x] Unit testing

Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] The commit message/PR follows our guidelines

Other information:

Summary by CodeRabbit

New Features
- Introduced a new message indicating no violations for a specific asset.
Bug Fixes
- Updated conditional rendering in compliance module to handle data errors more effectively.
- Corrected error message display by removing the unnecessary image tag.
Style
- Added a font-size property to error message styling for improved readability.
Improvements
- Enhanced compliance dashboard by adding a method to fetch compliance data automatically on initialization.

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent updates to the web application involve refining error messages, enhancing compliance data handling, and improving UI elements. Notable changes include updating error message text and formatting, adding a new method to fetch compliance data, and modifying the rendering logic of certain UI components. These changes aim to improve user experience and data clarity.

Changes

File Path	Change Summary
`.../asset-details/asset-details.component.ts`	Updated `this.violationErrorMessage` assignment from `'noDataAvailable'` to `'noViolationsForAsset'`.
`.../compliance/card/card.component.html`	Modified conditional rendering of `mat-card-actions` based on `card.footer` presence and `dataError` absence.
`.../compliance/compliance-dashboard/compliance-dashboard.component.ts`	Added `getComplianceData()` method to `ngOnInit()` function.
`.../shared/constants/messages.ts`	Removed `title` and `image` fields from `noPolicyFound` object; added `noViolationsForAsset` object.
`.../shared/error-message/error-message.component.css`	Added `font-size: 16px;` to the CSS rule for a specific class.
`.../shared/error-message/error-message.component.html`	Removed the `<img>` tag bound to `errorMessages.image`.

Poem

In code's embrace, we tweak and mend,
Compliance data, we now extend.
No violations, clear and bright,
Error messages, set just right.
With fonts refined and cards anew,
Our web app shines, for all to view.
🌟🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.