Closed go-jay closed 1 month ago
The recent changes in the PolicyKnowledgebaseDetailsComponent
involve enhancing the way image sources are set in the HTML template. Instead of using direct conditional logic within the template, a new method getImageSource
is introduced in the TypeScript file to determine the image source based on the autoFixAvailable
property of policyDetails
.
File Path | Change Summary |
---|---|
webapp/src/app/pacman-features/modules/compliance/policy-knowledgebase-details/...component.html |
Updated the src attribute of an image element to use [src]="getImageSource(policyDetails)" . |
webapp/src/app/pacman-features/modules/compliance/policy-knowledgebase-details/...component.ts |
Added a new method getImageSource(policyDetails: any): string to the PolicyKnowledgebaseDetailsComponent class. |
sequenceDiagram
participant User
participant PolicyKnowledgebaseDetailsComponent
participant HTMLTemplate
User->>PolicyKnowledgebaseDetailsComponent: View Policy Details
PolicyKnowledgebaseDetailsComponent->>HTMLTemplate: Call getImageSource(policyDetails)
HTMLTemplate->>PolicyKnowledgebaseDetailsComponent: Render Image with Source
In the land of code where changes bloom,
A rabbit hops with joy and room.
Images now with logic clear,
Fetching sources without fear.
A method born from clever mind,
To keep our code so well-aligned.
🐇✨
[!WARNING]
Review ran into problems
Problems (1)
* Git: Failed to clone repository. Please contact CodeRabbit support.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
No data about Duplication
Description
https://paladincloud.atlassian.net/browse/UIUX-708
Ensure that the policy name is always in camel case on both the admin policy details and user policy details screens.
Problem
Solution
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Other Information:
List any documentation updates that are needed for the Wiki
Summary by CodeRabbit