PaladinCloud / CE

Paladin Cloud is an extensible, cloud security platform for developers. Join the community at https://discord.gg/xvCFD29Jj4
https://paladincloud.io/
Apache License 2.0
561 stars 51 forks source link

fix:[CORE-2050]Adding More logs during Azure Collector failures #2270

Closed AnandPaladin closed 3 weeks ago

AnandPaladin commented 1 month ago

Description

This is related to https://paladincloud.atlassian.net/browse/CORE-2050. We are encountering Azure-Collector Job Failure issue which triggered Datadog alert for Vertex. With current code, we are unable to figure out which exact collector job failure indeed caused datadog alert since error count gets incremented during collector failures. Hence I have added more logs which might help us to narrow the root cause for collector failures

Problem

Azure collector jobs gets failed at Vertex

Solution

Adding more logs as of now to figure out exact collector causing this datadog alert issue

Fixes # (issue if any)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

Other Information:

List any documentation updates that are needed for the Wiki

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent updates primarily focus on enhancing the error handling and logging mechanisms across various inventory collectors in the Azure Discovery module. The changes introduce detailed error messages, increment error counts, and improve debug logging to provide clearer insights into issues during subscription data collection.

Changes

Files Change Summary
.../ActivityLogsCollector.java Enhanced error handling and logging with subscription details.
.../BatchAccountInventoryCollector.java
.../BlobContainerInventoryCollector.java
.../BlobServiceInventoryCollector.java
.../KubernetesServicesCollector.java
Updated exception handling for detailed logging and error count tracking.
.../DatabricksInventoryCollector.java
.../MariaDBInventoryCollector.java
.../MySQLInventoryCollector.java
.../NamespaceInventoryCollector.java
.../PolicyStatesInventoryCollector.java
.../PostgreSQLInventoryCollector.java
.../SCRecommendationsCollector.java
.../SearchServiceInventoryCollector.java
.../SecurityAlertsInventoryCollector.java
.../SecurityPricingsInventoryCollector.java
.../SitesInventoryCollector.java
.../SubnetInventoryCollector.java
Enhanced error logging, exception variable renaming, and error count logging.
.../VaultInventoryCollector.java
.../VirtualMachineScaleSetCollector.java
.../WebAppInventoryCollector.java
.../WorkflowInventoryCollector.java
Detailed error message logging with subscription details and incremented error count.
.../AssetFileGenerator.java Improved error logging with descriptive messages and error count tracking.

In fields of code, where errors bloom, Logs now capture every gloom. With counts that rise and details clear, We face the bugs without a fear. A rabbit’s cheer, so bright and loud, For code that stands so strong and proud.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud