Closed AnandPaladin closed 2 months ago
In the PacmanRuleEngine 2.0
, the status terminology used in PacmanSdkConstants
and AuditUtils
was standardized, replacing "EXEMPTED" with "EXEMPT" for consistent UI display across audit logs.
File Paths | Change Summary |
---|---|
.../PacmanSdkConstants.java |
Replaced STATUS_EXEMPTED with STATUS_EXEMPT and added comments to STATUS_SUCCESS |
.../AuditUtils.java |
Modified createAuditTrail method to change status from "EXEMPTED" to "EXEMPT" |
Objective | Addressed | Explanation |
---|---|---|
Audit Log status display consistency (CORE-2045) | ✅ |
In the code's quiet night,
Constants dance in new light,
Exempted now, just "EXEMPT,"
Audit logs, now more prompt,
Bugs and issues take their flight!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Description
When Policy engine runs and see the violation status as "exempt" due to User's action (when Admin approves exemption request or Admin add them), System populates Audit log entry showing "Exempted". But for UI consistency this has to be displayed as "Exempt" because all user's action entries are showing as "Exempt" which is standard defined status as per new Audit log design.
Problem
The root cause of the problem is audit log is simply using the issue status coming from ES which always stored "exempted" when violation is exempted.
Solution
For Audit log , we need to add condition for modifying the status to "EXEMPT"
Fixes # (issue if any)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration Test screen shot post fix
Checklist:
Other Information:
List any documentation updates that are needed for the Wiki
Summary by CodeRabbit