[PLG-637] Use Policy params retentiondays in Policy class.

arunpaladin commented 2 months ago

PLG-637 Use Policy params retention days in Policy class.

Set NSG flow log retention period >= N days Set Retention Duration To 'Greater Than N Days' For SQL Server Use Policy params retention days in Policy class. and modified the order of the Tag Name and Tag Value for "Enable Encryption For Application Tier Disk Volumes Using CMK" Policy

Problem

Solution

Fixes # (issue if any)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Chore (no code changes)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] My code follows the style guidelines of this project
[ ] My commit message/PR follows the contribution guidelines of this project
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Other Information:

List any documentation updates that are needed for the Wiki

Summary by CodeRabbit

New Features
- Enhanced policy management with configurable retention duration for Network Security Group flow logs.
- Introduced a new parameter naming convention for better clarity in policy parameters.
Bug Fixes
- Corrected parameter handling by updating the expected naming convention.
Improvements
- Improved error handling and logging for retention duration validation.
- Updated policy descriptions to reflect dynamic retention periods instead of fixed values.

coderabbitai[bot] commented 2 months ago

Walkthrough

The modifications enhance the flexibility and clarity of policy management regarding retention durations for various security logs. Key changes include generalizing retention parameters, updating policy names, and improving error handling. The adjustments aim to provide a dynamic approach to compliance checks, allowing configurations based on user-defined retention periods.

Changes

Files	Change Summary
`installer/resources/pacbot_app/files/DB_Policy.sql`	Updated SQL insert and update statements to generalize retention periods for policies, renamed parameters for clarity, and removed outdated policy entries.
`jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/azurerules/NSGRule/NetworkFlowLogRetentionRule.java`	Enhanced retention policy flexibility by introducing a configurable parameter, updated method names and logic to accommodate dynamic retention checks.
`jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/azurerules/SQLServer/SetRetentionDaysGreaterThanNinety.java`	Modified policy to validate against a configurable retention duration, updated annotations and method names, and improved error handling.
`jobs/pacman-awsrules/src/main/java/com/tmobile/cloud/azurerules/VirtualMachine/EncryptionAppTierRule.java`	Adjusted parameter name handling to align with new conventions without altering the overall control flow.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PolicyManager
    participant Database
    User->>PolicyManager: Set retention duration
    PolicyManager->>Database: Update retention settings
    Database-->>PolicyManager: Confirm update
    PolicyManager-->>User: Acknowledge configuration

🐇 In fields of green, where rabbits play,
New rules have come to brighten the day.
With flexible days and names so bright,
Our policies now feel just right!
Hops of joy, let’s dance and cheer,
For changes made bring us good cheer! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.