search

PalashBansal / Pacman

Game based on collision detection in Javascript
http://palashbansal.github.io/Pacman
MIT License
3 stars 4 forks source link

Collision Detected! Game Over! message not good. #10

Closed PalashBansal closed 4 years ago

PalashBansal commented 4 years ago

Description of the Issue

"Collision Detected! Game Over!" message appears below game objects(red ball and probably white obstacles)

Steps to Reproduce the Issue

  1. Play game and lose by colliding red ball while ball is in middle of game screen

Expected Behavior

"Collision Detected! Game Over!" should be topmost layer

Actual Behavior

Some part of text "Collision Detected! Game Over!" gets hiddden behind red ball.

image

Better improvement-

"Collision Detected! Game Over!"

  1. in top most layer
  2. with bigger font size
  3. with color of better visibility(not green)
PalashBansal commented 4 years ago

@aneeshababy Have a look please.

PalashBansal commented 4 years ago

Issues fixed with commit- https://github.com/PalashBansal/Collision/commit/ad1dc909d5ea8433ad9b48f42683f22d39bf6469

  1. now shorter text.
  2. on top most layer
  3. with bigger font size color is still green, but shows better visibility due to increased size.