search

PalashBansal / Pacman

Game based on collision detection in Javascript
http://palashbansal.github.io/Pacman
MIT License
3 stars 4 forks source link

fixed best score bug #37

Closed astriskit closed 4 years ago

astriskit commented 4 years ago

using session-storage will keep track of the session-storage until the tab is closed addressed #7

PalashBansal commented 4 years ago

Thanks for the fix, I will test and take decision accordingly.

PalashBansal commented 4 years ago

@astriskit I fetched changes but couldn't see score being saved, nor does it reflect in UI. Can you please look into once and help me in testing it. image

astriskit commented 4 years ago

@PalashBansal - try this:

Play once. Note the "current score". Play again and notice that once you cross your last "current score", it will start updating. Will add necessary code next. If there is any other relevant observation, you found, let me know.

Basically, the state is not being reflected correctly in view.

I won't be able to change anything in this PR - since the forked repo now stands deleted! Hence will remove this PR, but would send another PR referencing the same issue.

astriskit commented 4 years ago

Continue to - #38