search

Palashio / libra

Ergonomic machine learning for everyone.
http://libradocs.org/
MIT License
1.92k stars 109 forks source link

Travis CI: Add tests for undefined names, etc. #342

Closed cclauss closed 3 years ago

cclauss commented 4 years ago

name: b) New feature about: Select this if you're adding a new feature to libra. labels: feature

This pull request closes #issue_number_here .

- What I did

- How I did it

- How to verify it

This pull request adds a new feature to libra. @Palashio, could you please take a look at it?

Palashio commented 4 years ago

this build is failing @cclauss

cclauss commented 4 years ago

Yes. It fails because the code is missing some key import statements and contains three pip statements which are not valid Python syntax.

cclauss commented 4 years ago

@Sar1hak can you please take a look at the changes made in #324 because they are based on the presence of an undefined variable x which is failing these lint tests.

./libra/modeling/prediction_model_creation.py:14:44: F821 undefined name 'x'
    key=[k for k,v in add_layer.items() if x in v]
                                           ^
./libra/modeling/prediction_model_creation.py:54:46: F821 undefined name 'x'
    key = [k for k,v in add_layer.items() if x in v]
                                             ^