Palats / mapshot

Factorio mod to export maps as zoomable html
Apache License 2.0
77 stars 12 forks source link

Mod incompatibility: allow filtering of mods #27

Open AstraLuma opened 1 year ago

AstraLuma commented 1 year ago

Not sure what can be done about this, but imma drop it here:

It looks like Pause instead of catching up is incompatible with the mapshot CLI.

It causes the process to just stop.

Palats commented 1 year ago

Factorio mods are really tied to the sync'ed loop of Factorio - and thus do nothing when in pause as it would risk desync'ing the game. That includes running screenshotting and/or setting out of pause from the script (Rseding91 do confirms).

Given that the CLI do fiddle with a few things, there might be something in that direction, however:

So, long story short, I don't think there is anything doable here, so, closing unfortunately. (Obv. if you have a specific idea on how to avoid this problem, I'm all ears).

AstraLuma commented 1 year ago

The pause state doesn't seem to be saved (at least in this case), and simply removing the mod seems to clear the problem up.

Given that the mapshot cli already copies the mod directory, putting a filter on that process seems relatively easy?

In the short term, I'll just add a script to my pipeline to remove it.

Palats commented 1 year ago

Ah, thanks for the clarification - indeed, adding a way to filter out mods on the CLI would be straightforward and potentially useful.