search

Paldom / SpinnerDialog

PhoneGap waiting dialog plugin with spinner for Android, iOS and Windows Phone 8.
MIT License
68 stars 70 forks source link

Spinner Dialog not displayed in Windows Phone FullScreen Mode #14

Open writeosahon opened 9 years ago

writeosahon commented 9 years ago

@Paldom @EddyVerbruggen Happy New Year!! I'm using the Spinner Dialog plugin to develop an Android & Windows Phone App. The Windows Phone version of my app is created in Full Screen mode. Unfortunately, the Spinner Dialog is ONLY displayed on Windows Phone when the app is NOT in Full Screen mode. This is because, you opted for a dialog that ONLY displays in the status bar. (See 1st Attached Image) wp8-screenshot. Please, I suggest that the Windows Phone Spinner dialog should be made more modal and obvious like its Android and iOS counterparts. Windows Phone does offer a full screen dialog (See 2nd & 3rd Attached Images) wp_ss_20141226_0003 wp_ss_20141226_0002 I believe that my suggested approach will ensure that the Spinner Dialog is ALWAYS displayed on Windows Phone (whether in normal mode or Full Screen mode). Furthermore, I don't believe that this change will affect your Windows Phone code.

Thanks for listening. Hope you make the changes soon :)

Paldom commented 9 years ago

hi @writeosahon, you're right, that would be much better indeed. I've been dealing with this issue previously, but as I know there is no specific API to make modal like progress bar on WP8, so it's going to be a greater task to make it working, hope to have time for that soon. Any contributions also welcomed :)

writeosahon commented 9 years ago

Hello @Paldom , Thanks for the speedy response. Unfortunately, I don't program in native CS. So I can't contribute to the plugin directly. However, I will try to drum-up some help and attention to solve this issue. I also hope @EddyVerbruggen can provide some input and help solve this if possible.

I look forward to any new developments on the plugin. Cheers!!

writeosahon commented 9 years ago

Hi @Paldom . Glad to see you've received the pull Request from the Telerik fork about my Windows Phone Full Screen issue :) Please can you push the changes to the cordova.io registry so I can make use of it? Cordova registry still has previous version 1.3.0 Hope to hear from you soon. (Need to test the plugin before the demo of my app in the office on Monday)

Thanks!!

writeosahon commented 9 years ago

@Paldom just pinging to remind you to please push the plugin version 1.3.1 update to Cordova Registry. So I can use in my Windows phone app. Have a cool Sunday. Thanks.

Paldom commented 9 years ago

Hi @writeosahon, It's done: http://plugins.cordova.io/#/package/hu.dpal.phonegap.plugins.spinnerdialog ;)

writeosahon commented 9 years ago

@Paldom thanks you're a life saver !! :)

Cheers!!