querystring stringification patch

[Discountrobot]

Came across a minor issue when passing objects as querystrings :) this patch includes fixes for:

• querystring parameters aren't JSON.stringified resulting in objects being passed as "http://localhost?filter=[object Object]"
• optional querystring parameters aren't filtered out, when empty, resulting in requests like http://localhost?filter=undefined

[Paldom]

Thanks @Discountrobot, both are great considerations! :) I've merged, but in fact, I have some thoughts about this issue:

• querystirngs are strings in the most cases, maybe we should keep its type to be a string, and if you need object you should call JSON.stringify manually
• typescript function params could be easily optional (http://www.typescriptlang.org/Handbook#functions-optional-and-default-parameters), so filtering undefined might be useless. Moreover filtering http://localhost?filter=undefined could be confusing, when you accidentally pass sg undefined and debug it with capturing network communication.

What do you think?

ps: sorry for Travis error, I'm working on CI build (and test).

[Discountrobot]

After reviewing, i actually agree - that stringifying should happen outside of the base rest-client :)

As for the filtering, marking a query as optional, will still add it to the paramBuilder descriptor - regardless of the value

    @GET("/")
    public find( @Query("filter") filter?: IFilter): Promise<any> { return null }
   // SomeService.find() => http://localhost?filter=undefined
   // SomeService.find('something') => http://localhost?filter=something

Also, why have you chosen to implement the IRequest interface, rather than implementing the https://angular.io/docs/ts/latest/api/http/RequestOptions-class.html ?

[Paldom]

I'll look after why optional params not working, it was correct before, without any filtering.
You're right, RequestOptions is much better for request encapsulation (and later, for response). The only reason for using custom IRequest is not having enough time to look after the Angular2 way for that :)