search

Palente / SeeDevice

A pmmp plugin for Minecraft(W10,BE) [PHP]
GNU General Public License v3.0
14 stars 4 forks source link

Internal server error #3

Closed Takabrycheri closed 5 years ago

Takabrycheri commented 5 years ago

Hi, if the command is executed by a player without the perm, he gets kicked for Internal server error

Here the error:

[06:58:06] [Server thread/DEBUG]: #0 src/pocketmine/command/SimpleCommandMap(270): SeeDevice\Commands\SD->execute(object pocketmine\Player, string[9] seedevice, array[0])
[06:58:06] [Server thread/DEBUG]: #1 src/pocketmine/Server(2029): pocketmine\command\SimpleCommandMap->dispatch(object pocketmine\Player, string[9] seedevice)
[06:58:06] [Server thread/DEBUG]: #2 src/pocketmine/Player(2231): pocketmine\Server->dispatchCommand(object pocketmine\Player, string[9] seedevice)
[06:58:06] [Server thread/DEBUG]: #3 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(240): pocketmine\Player->chat(string[10] /seedevice)
[06:58:06] [Server thread/DEBUG]: #4 src/pocketmine/network/mcpe/protocol/CommandRequestPacket(54): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleCommandRequest(object pocketmine\network\mcpe\protocol\CommandRequestPacket)
[06:58:06] [Server thread/DEBUG]: #5 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(110): pocketmine\network\mcpe\protocol\CommandRequestPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
[06:58:06] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/protocol/BatchPacket(123): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\CommandRequestPacket)
[06:58:06] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(110): pocketmine\network\mcpe\protocol\BatchPacket->handle(object pocketmine\network\mcpe\PlayerNetworkSessionAdapter)
[06:58:06] [Server thread/DEBUG]: #8 src/pocketmine/Player(3126): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
[06:58:06] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/RakLibInterface(169): pocketmine\Player->handleDataPacket(object pocketmine\network\mcpe\protocol\BatchPacket)
[06:58:06] [Server thread/DEBUG]: #10 vendor/pocketmine/raklib/src/server/ServerHandler(99): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string[17] 192.168.0.3 43288, object raklib\protocol\EncapsulatedPacket, integer 0)
[06:58:06] [Server thread/DEBUG]: #11 src/pocketmine/network/mcpe/RakLibInterface(109): raklib\server\ServerHandler->handlePacket()
[06:58:06] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(99): pocketmine\network\mcpe\RakLibInterface->process()
[06:58:06] [Server thread/DEBUG]: #13 vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
[06:58:06] [Server thread/DEBUG]: #14 vendor/pocketmine/snooze/src/SleeperHandler(85): pocketmine\snooze\SleeperHandler->processNotifications()
[06:58:06] [Server thread/DEBUG]: #15 src/pocketmine/Server(2348): pocketmine\snooze\SleeperHandler->sleepUntil(double 1565416686.3363)
[06:58:06] [Server thread/DEBUG]: #16 src/pocketmine/Server(2205): pocketmine\Server->tickProcessor()
[06:58:06] [Server thread/DEBUG]: #17 src/pocketmine/Server(1784): pocketmine\Server->start()
[06:58:06] [Server thread/DEBUG]: #18 src/pocketmine/PocketMine(275): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[49] D:\dati\Server Minecraft\TakaServer 4.0 MCPE\HUB\, string[57] D:\dati\Server Minecraft\TakaServer 4.0 MCPE\HUB\plugins\)
[06:58:06] [Server thread/DEBUG]: #19 src/pocketmine/PocketMine(299): pocketmine\server()
[06:58:06] [Server thread/DEBUG]: #20 (1): require(string[104] phar://D:/dati/Server Minecraft/TakaServer 4.0 MCPE/HUB/PocketMine-MP.phar/src/p)
[06:58:06] [Server thread/INFO]: [-] Takabrycheri34
[06:58:06] [Server thread/INFO]: Takabrycheri34[/192.168.0.3:43288] disconnesso a  causa di Internal server error

Also I already fixed myself editing that line (25).

Original code:

if(!$this->testPermission($sender)){
    return $sender->sendMessage(self::$pr.TranslationContainer("commands.generic.permission"));
}

Fixed code:

if(!$this->testPermission($sender)){
    return;
}

The no permission error will printed anyway and the plugin haven't error in console and don't kick player.

Sorry for my English. I hope you fix it on the repo :) Bye

PS: nice plugin :D

Palente commented 5 years ago

Hey, thanks for your report. i don't see why it make error. Btw i'm remaking the plugin so i think the bug will be fixed.