search

Palindrom / JSONPatcherProxy

ES6 proxy powered JSON Object observer that emits JSON patches when changes occur to your object tree.
94 stars 14 forks source link

disableTraps() vs revoke() #37

Open warpech opened 5 years ago

warpech commented 5 years ago

It is not clear to me what's the point of having the two public methods disableTraps() and revoke(). In the tests, they are always tested separately.

In real life usage, shouldn't I use both of them?

If it was up to me, I would merge these methods into one. But maybe I am missing something.

I checked if they are used in Palindrom and they are not.

cc @alshakero, @tomalec.