Open warpech opened 5 years ago
It is not clear to me what's the point of having the two public methods disableTraps() and revoke(). In the tests, they are always tested separately.
disableTraps()
revoke()
In real life usage, shouldn't I use both of them?
If it was up to me, I would merge these methods into one. But maybe I am missing something.
I checked if they are used in Palindrom and they are not.
cc @alshakero, @tomalec.
It is not clear to me what's the point of having the two public methods
disableTraps()
andrevoke()
. In the tests, they are always tested separately.In real life usage, shouldn't I use both of them?
If it was up to me, I would merge these methods into one. But maybe I am missing something.
I checked if they are used in Palindrom and they are not.
cc @alshakero, @tomalec.