search

Palindrom / JSONPatcherProxy

ES6 proxy powered JSON Object observer that emits JSON patches when changes occur to your object tree.
94 stars 14 forks source link

Use Proxy.revokable and add revokeProxy to API #4

Closed alshakero closed 7 years ago

alshakero commented 7 years ago

I'm implementing the needed specs right now.

Implements: https://github.com/Palindrom/Palindrom/issues/134

tomalec commented 7 years ago

Just added a comment at https://github.com/Palindrom/JSONPatcherProxy/pull/4/files/a50598b02b1a7c4f34e89afcf5e902defeb83d52#r115702691 but GH hides it.

alshakero commented 7 years ago

@tomalec here is my response in case it was hidden: https://github.com/Palindrom/JSONPatcherProxy/pull/4#discussion_r115706017

alshakero commented 7 years ago

@tomalec I think this is ready for review.

alshakero commented 7 years ago

@tomalec is this good to merge?

tomalec commented 7 years ago

Overall I think it's just cosmetics, but unobserve suite in test is quite confusing to me, wouldn't it be cleaner to have separate section for pause?

alshakero commented 7 years ago

@tomalec we have done all kinds of breaking changes, why should we keep unobserve in its current utterly useless case. I removed it and stuck with pause, resume, and disableTraps. And cleaned up the tests.

alshakero commented 7 years ago

Is this good to go?