do not proxify objects that are values of non-patchable array properties

Palindrom / JSONPatcherProxy

ES6 proxy powered JSON Object observer that emits JSON patches when changes occur to your object tree.

94 stars 14 forks source link

do not proxify objects that are values of non-patchable array properties #47

Closed warpech closed 5 years ago

warpech commented 5 years ago

because such problem happens in Vue 2 and it results in an invalid patch. See: https://github.com/vuejs/vue/issues/427, https://github.com/vuejs/vue/issues/9259

warpech commented 5 years ago

All addressed. Pleasee re-review.

Do we plan to revert this change eventually, once Vue 3 would become mature enough?

I don't think so. This change is useful general and the problem is not specific only to Vue. It just happens that Vue 2 is a very high profile framework that exhibits this problem.