Closed palisadoes closed 1 year ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
We do this to ensure the overall reliability of the code base is maintained. This is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
Contacting the person who assigned the mentors is not advised unless they make a request. Do not @ the person who did the assignment otherwise.
Our Pull Request Approval Process
We have these basic policies to make the approval process smoother for our volunteer team.
Testing Your Code
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
We do this to ensure the overall reliability of the code base is maintained. This is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Reviewers
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your Code
Your reviewer(s) will have the following roles:
Contacting the person who assigned the mentors is not advised unless they make a request. Do not @ the person who did the assignment otherwise.