Admin - Add support for Action Items

[meetulr]

Is your feature request related to a problem? Please describe. Adding support for Action Items in talawa-admin.

Describe the solution you'd like

1. A screen for action item categories on the org leftDrawer, through which we could create, edit and view all the categories.
2. A screen for action items on the org leftDrawer, for similar crud functionalities. We could also add custom filter and search functionality for getting action items for a single category, assigned to a certain user, etc.
3. A screen on the event dashboard for action items associated with that event (as was previously the case for event projects). Here also, aside from the basic crud, we could add filter search functionality like the one described above.

Additional context It's a companion issue for this one in the api.

[meetulr]

As mentioned, this is a companion issue for the one in the api. And as discussed, it will also serve as an evaluation for the pr I opened for the corresponding issue. Please assign it to me so that I can start working on it.

[github-actions[bot]]

Congratulations on making your first Issue! :confetti_ball: If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

[meetulr]

@palisadoes Please let me know if the solution I proposed is acceptable, and if anything else is required.

[palisadoes]

Layout

1. Action Item CRUD (Organization wide), your suggestion is OK
2. Action Item CRUD (Event specific), your suggestion is OK
3. Category CRUD should be on the organization settings page, however we are doing some redesigns for it that will cause merge conflicts. Your suggestion is OK, and when the redesign work is complete we can rearrange things

Other

1. Make sure your designs are in keeping with our design standards. The Figma file can be found here:
   • https://docs.talawa.io/docs/design/ux/ux-design-system
2. We'll need your Figma designs to be added to the project's when you are done

[palisadoes]

@rishav-jha-mech @aashimawadhwa This is an issue to watch. There will be some design modifications required.

[meetulr]

Layout

1. Action Item CRUD (Organization wide), your suggestion is OK
2. Action Item CRUD (Event specific), your suggestion is OK
3. Category CRUD should be on the organization settings page, however we are doing some redesigns for it that will cause merge conflicts. Your suggestion is OK, and when the redesign work is complete we can rearrange things

Other

1. Make sure your designs are in keeping with our design standards. The Figma file can be found here:

   • https://docs.talawa.io/docs/design/ux/ux-design-system
2. We'll need your Figma designs to be added to the project's when you are done

Could you please elaborate on that third point. Categories should be on the organization settings page? Could you direct me to the issue addressing the redesign that you mentioned.

Also, please assign me so that I can start working on it. Thanks.

[palisadoes]

@meetulr

1. We will need to add your Figma page designs to our official Figma document
2. Please plan for this

[palisadoes]

This is the issue that will be modifying the Organization Settings page. Categories are going to be organization wide. Moving the CRUD for this to the settings page leaves the main left drawer for the most commonly accessed features.

• https://github.com/PalisadoesFoundation/talawa-admin/issues/1457

[meetulr]

Alright! Thank you.

[meetulr]

@aashimawadhwa @rishav-jha-mech Where do we want action items on the event dashboard:

Shall I put them below the details:

I could add some designs in the details later.

[palisadoes]

Access the volunteers via a button below this one.

[meetulr]

Could you please clarify😅. We need a custom sort and filter functionality for action items right? (Like that in the organizations list).

Would it be ok to keep the search bar and Action Item cards directly below the event details? Like Projects used to be? (To view all the action items, and perform operations on them directly from there).

[palisadoes]

Every button on this page is related to showing a different aspect of event detail. We need separate detail for action items.

The button on the screen should be below the box in my previous comment

What type of sorting and search were you planning on providing?

[meetulr]

Yes, so everything related to action items should be inside a modal, accessible from the left drawer in the event options (below the check in registrants)?

About the search, I was thinking we should be able to sort the action items (latest/oldest). And, to be able to filter them, by actionItemCategoryId or status, for better monitoring and management.

Would that be ok?

[palisadoes]

The API PR has been merged

• https://github.com/PalisadoesFoundation/talawa-api/pull/1648

[palisadoes]

Yes, so everything related to action items should be inside a modal, accessible from the left drawer in the event options (below the check in registrants)?

About the search, I was thinking we should be able to sort the action items (latest/oldest). And, to be able to filter them, by actionItemCategoryId or assigneeId, for better monitoring and management.

Would that be ok?

I was thinking that for an event, the sort and search features won't be necessary as they would be rarely used. Then I realized that for general non-event activities there could be many items.

Your suggestion is OK. Please proceed.

[palisadoes]

@meetulr

Your PR for the API was much too large. Dozens of files and thousands of lines of code. This issue will need to be split into at least 3 separate PRs.

1. Category CRUD
2. Non-Event Action Item CRUD
3. Event Action Item CRUD

[meetulr]

Yes, thank you! That would be more convenient for everyone.

[meetulr]

Where do I put the section for action item category on the settings page?

[palisadoes]

1. Consider a new left drawer for settings
   1. One button for general settings like what we have
   2. Another button for creating Action Item categories
2. Have a back arrow to get back to the main menu
3. The left drawer title must be Settings, not Menu

[meetulr]

So, a new leftDrawer for the orgSettings screen (like the event leftDrawer for event dashboard)? This leftDrawer would contain options like event options in the event leftDrawer.

Here we would currently have three options:

1. General settings.
2. Action Item Categories.
3. Back arrow to the main menu.

Is that what you mean?

By the way, are we going to have some other organization specific things like action item categories that would be added to the options of this new left drawer?

[palisadoes]

1. Yes, there will be new organization specific parameters to edit.
2. Yes, like the event details
3. In your original note you said that "Action Item Categories have only it's name to show". You could consider a misc button which goes to a screen with tabbed sections, like the user profile pages design in the Admin figma here. One tab would cover Action Item categories.
   1. https://docs.talawa.io/docs/design/ux/ux-design-system

[meetulr]

Yes, I like the tabs approach:

https://github.com/PalisadoesFoundation/talawa-admin/assets/55585268/9e2210d7-1233-4e61-b186-2619c28a84c6

We could just add more tabs here for upcoming organization specific features. It's just for the tabs sample. I would improve on the categories design. And add modals for create and edit functionalities.

Is that ok?

[palisadoes]

The tabs need to follow our design scheme with a white background, grey borders like in the Figma document.

• https://www.figma.com/file/WksD4uIa5sQJMIk3pR4l0c/Talawa-Design-System-(Official)?type=design&node-id=307-212&mode=design&t=9mErk5fwtC7PLwY2-0

[meetulr]

Yes, I'll make the design adjustments. Thank you.

[meetulr]

https://github.com/PalisadoesFoundation/talawa-admin/assets/55585268/c32ac34c-b31c-460f-b626-76a20b027b38

Is that ok for general settings?

[palisadoes]

1. Make the corners rounder to match the Figma

   

2. Use the same background color as the Figma. It should already be in the CSS

3. Use the same color for the lines around the button as the Figma

[meetulr]

This is a demo:

https://github.com/PalisadoesFoundation/talawa-admin/assets/55585268/600bdbc8-3479-41ab-88b5-520140c80d00

[palisadoes]

This looks good. Please submit your PR

[meetulr]

Alright, I'll add the tests and open a pr tomorrow.

[meetulr]

How's this design for action items (organization wide)

[palisadoes]

1. One row per entry. It's more intuitive.
2. We are going to have to migrate to that approach across the app

[meetulr]

[palisadoes]

1. This looks OK.
2. Can you provide the figma link to this designs so that we can add to our official one? We'll probably create issues to fine tune them later.
   1. @aashimawadhwa @rishav-jha-mech take note

[meetulr]

1. Category CRUD
2. Non-Event Action Item CRUD
3. Event Action Item CRUD

@palisadoes part 2 and part 3 of this issue are still remaining.

[meetulr]

1. This looks OK.

2. Can you provide the figma link to this designs so that we can add to our official one? We'll probably create issues to fine tune them later.

   1. @aashimawadhwa @rishav-jha-mech take note

Oh and I'm sorry I missed this comment. I'm learning figma. I'll make the designs and share the links😅.

[palisadoes]

1. Did you see that your PR didn't pass the tests after merging?
   1. https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/7863549480/job/21454284769#step:6:1127
2. Please resubmit to fix the apparent edge case

[meetulr]

Ok, I'll have to look into it.

[github-actions[bot]]

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

[meetulr]

A pr is up for review #1596, after this, one last pr would be required for event dashboard. Then the basic functionalities would be done.

[meetulr]

@palisadoes what will the home screen of the Event Dashboard ultimately display?

Currently, it only shows basic event information. Event-specific details, such as registrants, check-in registrants, action items, and event stats, are all accessed through the left drawer in the form of modals.

[palisadoes]

@palisadoes what will the home screen of the Event Dashboard ultimately display?

Currently, it only shows basic event information. Event-specific details, such as registrants, check-in registrants, action items, and event stats, are all accessed through the left drawer in the form of modals.

We'll be creating an issue for this via either @aashimawadhwa and/or @rishav-jha-mech

[meetulr]

@palisadoes what will the home screen of the Event Dashboard ultimately display? Currently, it only shows basic event information. Event-specific details, such as registrants, check-in registrants, action items, and event stats, are all accessed through the left drawer in the form of modals.

We'll be creating an issue for this via either @aashimawadhwa and/or @rishav-jha-mech

I'm sorry, I don't understand😅. I wanted to know what the home screen would eventually show. As all the event-specifics are currently in the left drawer. Is it not planned yet?

[palisadoes]

1. Understood. Yes, the default screen is bare.
2. We're working on a design

[palisadoes]

We'll need issues for the API and Admin to cover action items for recurring events