Open palisadoes opened 4 months ago
@palisadoes , I would like to work on this issue. Please assign it to me.
@palisadoes @aashimawadhwa @rishav-jha-mech
I had a doubt regarding the instructions provided in the issue. I need a bit of clarification regarding point 4.
In part 4 of the point, it's mentioned that
4. In the Super Admin screen, all organizations must be visible
In the figma design, the page categorizes organizations as created by the user, joined by the user, etc. When you mention "all organizations," are we supposed to display every single organization regardless of the category? If so,how will we be able to view the different types of organizations (like the organizations joined by user, created by user, etc.)?
Additionally, the part 2 mentions that
2. The only options should be for changing: 1. the blocking status 2. roles
Since these options are organization-specific, should we modify the UI to display these options corresponding to every organization on the page?
This is the UI of the page as per the Figma design:
manage
option as there is nowThe image you posted is not visible
@palisadoes @aashimawadhwa @rishav-jha-mech
I've prepared A design based on the instructions provided above.
Please review the design and confirm if it aligns correctly with the instructions.
I have a small suggestion though. According to the Figma designs shared, the user flow for a superadmin has a specific page for viewing all organizations. Now, if we're showing all organizations in the organizations tab within the user section, what would be the purpose of it? Wouldn't this be duplicating information?
As this page falls under the user section, shouldn't it display organizations related to the specific user instead?
Based on the current figma designs, here's the user flow for a superadmin:
Thanks for the observations.
Related to the organizations to view:
Based on this, it's best to focus on the current org in Admin and leave the multi-org options to the Super Admin. This would mean that the tab would be labeled Organization
in Admin, but Organizations
in Super Admin
@palisadoes @aashimawadhwa @rishav-jha-mech
I have changed the design of the card as per the requirements. Please take a look.
I have created this page design for superadmins:
Whereas for admins, only current organization will be displayed:
Please review the design and confirm if it aligns correctly with the requirements.
It may be better to have a standardized dropd own look and feel for this.
The disadvantages to this approach are:
Can you think of a better layout?
Since this issue involves working with People page, we can also add a task:
@Doraemon012
@palisadoes
I've created a design based on the card layout with dropdowns as suggested. Here's the image:
Following the recommendations, I've incorporated three dropdowns:
Additionally, I've used colors to enhance intuitiveness, such as green indicating "yes" and red indicating "no."
As the roles are assigned on an organization basis, I suggest disabling the role dropdown when the user is not a member of the particular organization.
While omitting the search and filter functionality, this would be the overall design of the page:
Please take a look.
...
) with a mouse over just in case.As the roles are assigned on an organization basis, I suggest disabling the role dropdown when the user is not a member of the particular organization.
It's member detail for that particular user in that specific Organization so we should only show one Org instead of showing all Orgs even when viewer is Non-Admin for other orgs. So where do we get disabled roles?
As the roles are assigned on an organization basis, I suggest disabling the role dropdown when the user is not a member of the particular organization.
It's member detail for that particular user in that specific Organization so we should only show one Org instead of showing all Orgs even when viewer is Non-Admin for other orgs. So where do we get disabled roles?
I overlooked that.
@Doraemon012 the logic would mean that we would never see tiles for disabled roles. You'll need to update this in your PR.
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
Unassigning due to no activity or open PR
@Cioppolo14 @palisadoes I am working on the issue. I have already created and fianilazied the figma designs as visible in the above comments. I have also raised a related PR in talawa-api repository. I will complete this as soon as possible. Please reassign this to me.
Are you still working on this?
@palisadoes I apologise for the delay. I was having my end semester exams. The code is almost ready. I'll raise a PR within next two days.
@palisadoes Please take a look at the screen recording below.
Does this functionality align with the requirements of the issue ?
Getting closer.
1. As this is an Admin specific screen, you should only see one organization listed. That would be the organization being edited.
Sorry for not being clear. The screen shown in the screen recording is the one for a
super admin
. As discussed, the super admin screen will containall the organizations
, while theadmin
screen will show only theselected organization
.2. You'll need to add translations for the dropdowns.
Sure, working on it.
3. What does "Conflicting Entry" mean in this context? It's not obvious to the user.
This is due to a bug in my code, I will fix it.
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
@Doraemon012 I closed your PR due to inactivity. We really need the output to match the Figma design. Are you willing to give it another try?
@palisadoes I apologize for the inactivity. I was waiting for the reviewer's feedback on the Figma design.
I'll fix the conflicting files first, and then we can either discuss the design or wait for the reviewer's response.
Please reopen my PR.
Thanks. Please reproduce the Figma design aesthetic for now.
Is your feature request related to a problem? Please describe.
The User management screens for Admin and Super Admin are very different
Admin
Super Admin
Describe the solution you'd like
Refer to our official figma design for the items below:
We need both to resemble the desired design in our official Figma. Where organization specific modifications are specified in the Organizations tab
The Organization People and Community Users screen must match that of the existing Organization People screen:
clicking on a row must invoke the User design
When the Organization tab is selected:
You will also need to standardize the titles.
members
, notpeople
andusers
. The word Talawa should be removedusers
.Describe alternatives you've considered
Approach to be followed (optional)
Additional context
Assistance:
Related Issues:
Potential internship candidates