Closed Ratul-Saha-003 closed 3 weeks ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
Read our CONTRIBUTING.md file. Most importantly:
@palisadoes Could I get a review on this PR?
@Ratul-Saha-003 Please fix the failing tests.
@Ratul-Saha-003 Please fix the failing tests.
I have added another PR for the failing tests as I had to change the name of the branch.
What kind of change does this PR introduce? Refactoring
Issue Number: Fixes #1926
Did you add tests for your changes? Already present(updated tests)
Snapshots/Videos:
If relevant, did you update the documentation? Updating Documentation isn't required
Summary Changed the Requests option to Membership Requests in multiple places.
Does this PR introduce a breaking change? No
Other information None
Have you read the contributing guide? Yes