PalisadoesFoundation / talawa-admin

Admin portal for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
114 stars 466 forks source link

Update Requests option to Membership Requests #1971

Closed Ratul-Saha-003 closed 3 weeks ago

Ratul-Saha-003 commented 3 weeks ago

What kind of change does this PR introduce? Refactoring

Issue Number: Fixes #1926

Did you add tests for your changes? Already present(updated tests)

Snapshots/Videos:

Screenshot from 2024-05-07 23-01-14

If relevant, did you update the documentation? Updating Documentation isn't required

Summary Changed the Requests option to Membership Requests in multiple places.

Does this PR introduce a breaking change? No

Other information None

Have you read the contributing guide? Yes

github-actions[bot] commented 3 weeks ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. :dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make
Ratul-Saha-003 commented 3 weeks ago

@palisadoes Could I get a review on this PR?

Cioppolo14 commented 3 weeks ago

@Ratul-Saha-003 Please fix the failing tests.

Ratul-Saha-003 commented 3 weeks ago

@Ratul-Saha-003 Please fix the failing tests.

I have added another PR for the failing tests as I had to change the name of the branch.