Closed GlenDsza closed 3 weeks ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
Read our CONTRIBUTING.md file. Most importantly:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.26%. Comparing base (
0632235
) to head (3ac87e0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@GlenDsza The introspection test is failing. Is that expected or should it be addressed?
@Cioppolo14 Introspection is going to fail for a few weeks. It's not a prerequisite for merging.
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes #1958
Did you add tests for your changes?
Yes
Snapshots/Videos:
https://github.com/PalisadoesFoundation/talawa-admin/assets/109027247/74c3c27b-f9bd-4459-83d7-aebbf281cded
Summary
Added relevant routes, And logic to redirect to admin Event Dashboard and User EventDashboard depending on role.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes