PalisadoesFoundation / talawa-admin

Admin portal for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
157 stars 650 forks source link

Upgrade package @testing-library/user-event from 12.8.3 to 14.5.2 #2072

Open palisadoes opened 5 months ago

palisadoes commented 5 months ago

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade @testing-library/user-event from 12.8.3 to 14.5.2.
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps @testing-library/user-event from 12.8.3 to 14.5.2.

Release notes

Sourced from @​testing-library/user-event's releases.

v14.5.2

14.5.2 (2023-12-29)

Bug Fixes

  • remove interop and deep DTL imports (6a3c896)

v14.5.1

14.5.1 (2023-09-15)

Bug Fixes

  • incorrect default import from @​testing-library/dom (#1162) (d7483f0)

v14.5.0

14.5.0 (2023-09-14)

Bug Fixes

  • exports: add a named export for userEvent (4019cee), closes #1146

Features

  • types: Add additional type exports for UserEvent & Options (#1112) (da00e8d)

v14.4.3

14.4.3 (2022-08-09)

Bug Fixes

v14.4.2

14.4.2 (2022-08-04)

Bug Fixes

v14.4.1

14.4.1 (2022-08-02)

... (truncated)

Commits
  • d036279 chore: upgrade node in codesandbox
  • 910fee5 chore: set tsconfig baseUrl
  • fa8d867 revert: swap release script
  • c4b4629 chore: upgrade testing environment
  • 6a3c896 fix: remove interop and deep DTL imports
  • d7483f0 fix: incorrect default import from @​testing-library/dom (#1162)
  • 4be87b3 chore: swap release script
  • d95121d chore: add --experimental-import-meta-resolve
  • 8779eae chore: format, lint, fix lint
  • 4019cee fix(exports): add a named export for userEvent
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
sahil-idk commented 5 months ago

i would like to work on this issue

github-actions[bot] commented 4 months ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

AradhyaDixit18 commented 4 months ago

Can I help in this issue ?

sahil-idk commented 4 months ago

After Updating the package to 14.5.2 i faced some act() issues with warnings that dependabot also faced

https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/9736356167/job/26866929956?pr=2065

Then after Going through the testing library documentation it shows the requirement of testing-library/dom package but once i run the tests again i encounter almost half tests failing which i am working on and any assistance will be appreciated @palisadoes @varshith257 image

palisadoes commented 4 months ago

Please ask the #talawa-admin slack channel for assistance

sahil-idk commented 4 months ago

@palisadoes i asked the slack , didnt get response but what i figured is the new version of user event requires a @testing-library/dom package which i installed but it leads to fail in tests as the libraray's test writing syntax had many changes in 13.5 and from there to 14.5 as well ( u can check them in @testing-library/user-event repository) which will require modifying those tests , so what should be the next course of action ?

varshith257 commented 4 months ago

@sahil-idk Yes, there are major changes from version 13. Refactor the changes needed according to docs of user -event library to update to latest version 14

github-actions[bot] commented 4 months ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Cioppolo14 commented 4 months ago

@sahil-idk Are you still working on this?

sahil-idk commented 4 months ago

@sahil-idk Are you still working on this?

I've been working on updating a package to a specific version, but now there are numerous changes in the test files. With around 50 failed tests to fix, it's becoming quite overwhelming. Could you suggest a more efficient solution for handling this situation?

github-actions[bot] commented 3 months ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

palisadoes commented 3 months ago

Unassigning. Inactivity

ManjariRathore commented 3 months ago

Hey @palisadoes, @varshith257 If possible can you assign this to me since one of the issues that i was working on has been closed. I will raise a draft PR asap.

github-actions[bot] commented 3 months ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

palisadoes commented 3 months ago

Unassigning. Inactivity

github-actions[bot] commented 2 months ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Kanishk-tiwari-045 commented 2 months ago

@palisadoes Can you please assign this to me? I am just about to raise a PR

github-actions[bot] commented 2 months ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

palisadoes commented 1 month ago

Unassigning. Inactivity

Kanishk-tiwari-045 commented 1 month ago

@palisadoes Sir I have nearly solved all the testcases, which were failing in my previous PR, Now i am about to push my recent work after solving 6 more of them. Can I be reassigned please?

gautam-divyanshu commented 1 month ago

@Kanishk-tiwari-045 any update on pr?

github-actions[bot] commented 1 month ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

palisadoes commented 1 month ago

Unassigning. Inactivity

Kunalpal216 commented 3 weeks ago

Can this issue be assigned to me @palisadoes ?

DEEpaK-reddY123 commented 3 weeks ago

hey @palisadoes please assign this to me

palisadoes commented 3 weeks ago

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

github-actions[bot] commented 1 week ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

palisadoes commented 1 week ago

Unassigning. Inactivity No PR

mohamedrehan1 commented 1 week ago

I have made a pull request #2468 Upgrade package @testing-library/user-event from 12.8.3 to 13.5.0 because if this pr is good i can work on upgrading to 14.5.2