PalisadoesFoundation / talawa-admin

Admin portal for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
152 stars 619 forks source link

Write Unittests for `src/utils/StaticMockLink.ts` #2367

Open palisadoes opened 4 weeks ago

palisadoes commented 4 weeks ago

We will need unittests done for all methods, classes and functions found in this file.

PR Acceptance Criteria

  1. When complete this file must show 100% coverage when merged into the code base.
  2. The current code coverage for the file can be found here
  3. CodeRabbit must approve all your changes to the test file(s) and the file(s) under test
  4. The PR will show a report for the code coverage for the file you have added. You can use that as a guide
  5. No functionality must be removed to achieve this goal
  6. All tests must be valid and truly test the code base

Other Criteria

  1. If this file isn't referenced in the code base then remove it. We don't want tests run on unused code

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

Manan024 commented 3 weeks ago

hey can i work on these @palisadoes

Kunalpal216 commented 2 weeks ago

If there are no updates by @Manan024 , Can this issue be assigned to me ?

Manan024 commented 2 weeks ago

I’ve finished the test, but there are some eslint issues coming up that I’m working on resolving. I’ll try to get it done today , if I can’t, you can take over okay @Kunalpal216 ?

Manan024 commented 2 weeks ago

@Kunalpal216 you can work on these

Kunalpal216 commented 2 weeks ago

Thanks. @palisadoes @pranshugupta54 please assign this to me.

palisadoes commented 2 weeks ago

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

github-actions[bot] commented 5 days ago

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Cioppolo14 commented 5 days ago

@Kunalpal216 Are you working on this?

aditya-bansal-7 commented 3 days ago

if there are no updates I can work on this issue?