PalisadoesFoundation / talawa-admin

Admin portal for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
146 stars 598 forks source link

Write Unittests for `src/screens/Users/Users.tsx` #2376

Open palisadoes opened 2 weeks ago

palisadoes commented 2 weeks ago

We will need unittests done for all methods, classes and functions found in this file.

PR Acceptance Criteria

  1. When complete this file must show 100% coverage when merged into the code base.
  2. The current code coverage for the file can be found here
  3. CodeRabbit must approve all your changes to the test file(s) and the file(s) under test
  4. The PR will show a report for the code coverage for the file you have added. You can use that as a guide
  5. No functionality must be removed to achieve this goal
  6. All tests must be valid and truly test the code base

Other Criteria

  1. If this file isn't referenced in the code base then remove it. We don't want tests run on unused code

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

syedali237 commented 2 weeks ago

Can I be assigned this issue?

palisadoes commented 2 weeks ago

Can I be assigned this issue?

Our policy is to assign no more than two issues to each contributor across all repositories. This way everyone gets a chance to participate in the projects. We sometimes give exceptions for more urgent cases and sometimes we lose track, but the policy stands. You have reached your limit, please wait until your existing issues are closed before requesting more issues. You could unassign yourself from one of the other issues too.

AnshulKahar2729 commented 2 weeks ago

Assign me this, I can work on this.

Kunalpal216 commented 1 week ago

If there are no updates by @AnshulKahar2729 , Can this issue be assigned to me ?

AnshulKahar2729 commented 1 week ago

If there are no updates by @AnshulKahar2729 , Can this issue be assigned to me ?

It's my exam time, I will make the pr soon.

palisadoes commented 5 days ago

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

AnshulKahar2729 commented 2 days ago

During the week of November 11, 2024 we will start a code freeze on the develop branches in Talawa, Talawa Admin and Talawa-API.

We have completed a project to convert the Talawa-API backend to use PostgreSQL. Work will then begin with us merging code in the develop branches to a new develop-postrgres branch in each repository.

Planning activities for this will be managed in our #talawa-projects slack channel. A GitHub project will be created to track specially labeled issues. We completed a similar exercise last year using a similar methodology.

Starting November 12, California time no new PRs will be accepted against the develop branch. They must be applied to the develop-postrgres branch.

There are some GSoC project features that will need to be merged into develop. These will be the only exceptions.

This activity and the post GSoC 2024 start date was announced in our #general Slack channel last month as a pinned post.

But my changes were in a branch which was created from the deploy branch, so am I supposed to do everything from develop-postgres branch?

palisadoes commented 1 day ago

Yes