PalisadoesFoundation / talawa-admin

Admin portal for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
156 stars 645 forks source link

Update PR GitHub Action to correct duplicated health check logic #2499

Open palisadoes opened 4 days ago

palisadoes commented 4 days ago

Is your feature request related to a problem? Please describe.

  1. The CodeRabbit.ai evaluated the content of the .github/workflows/pull-request.yml GitHub Action file in this PR and suggested changes
    1. https://github.com/PalisadoesFoundation/talawa-admin/pull/2498
  2. The changes can be found here:
    1. https://github.com/PalisadoesFoundation/talawa-admin/pull/2498/files#r1862058856
    2. https://github.com/PalisadoesFoundation/talawa-admin/pull/2498/files#r1862070303

Describe the solution you'd like

  1. Create a .github/workflows/scripts/health_check_no.sh script using a variant of the code suggested in the CodeRabbit.ai suggestion.
  2. The script must test both docker and non-docker functionality
  3. It must run in such a way that the functionality of the original GitHub action is not affected in any way.
  4. CodeRabbit.ai must approve your changes

Describe alternatives you've considered

Approach to be followed (optional)

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

sezallagwal commented 1 day ago

hey @palisadoes, can you assign this to me?