search

PalisadoesFoundation / talawa-api

API Backend for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
222 stars 804 forks source link

Upgrade package `typescript` from 5.3.3 to 5.4.2 #2026

Closed palisadoes closed 7 months ago

palisadoes commented 8 months ago

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

Upgrade typescript from 5.3.3 to 5.4.2.

Background Failing PRs

Release Note Details

Release notes

Sourced from typescript's releases.

TypeScript 5.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

Commits
  • 42bb138 Bump version to 5.4.2 and LKG
  • 992c705 Add release pipeline to release-5.4 (#57513)
  • db6b2a9 Bump version to 5.4.1-rc and LKG
  • bd4f51c Update LKG
  • 8a1f79d Merge remote-tracking branch 'origin/main' into release-5.4
  • d04e348 Improve apparent type of mapped types (#57122)
  • 86a1663 Update package-lock.json
  • feb57c2 Instantiate earlier inferred constraints in conditional types (#57362)
  • 91e67ff fix(57392): using is not suggested as a keyword (#57394)
  • 29c0024 Avoid creating rest elements with errorType when any is spread (#57116)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
AVtheking commented 8 months ago

I would like to work on this issue, though I have been assigned two issues already but the PR for the same are under review and the merging of them is blocked by PR freeze right now.

Cioppolo14 commented 8 months ago

@AVtheking I'm going to stick with the two issue policy right now. It looks like one of your PRs has some open comments and issues to work through, and I just assigned the other one for review so hopefully you get feedback soon.

gautam-divyanshu commented 7 months ago

@palisadoes @Cioppolo14 Please assign this issue to me.

palisadoes commented 7 months ago

@gautam-divyanshu Why have you closed so many PRs related to this?

gautam-divyanshu commented 7 months ago

@palisadoes I will make a new pr