Open palisadoes opened 6 months ago
I'd like to work on this issue!
Due to sudden academic commitments, I wouldn't be able to fix the issue in time, hence I have unassigned myself.
Can I work on this issue?
@palisadoes I think there is some confusion. There are no references to userType
in mutations and their tests. I think you searched userType
and TestUserType
was also included in this. Here userType
is altogether different from TestUserType
. Please see the images below. Please verify once again from the files.
Should it be renamed for clarity or do you feel it should remain, and why?
Should it be renamed for clarity or do you feel it should remain, and why?
I don't think there is any need of renaming. userType
and TestUerType
are able to express their difference by their name. Also it will lead to unnecessary refactoring. Rest I leave to you!
Thanks. Closing
Thanks. Closing
I think there is some mis-interpretation. There are some references of userType
in just 5-6 files. They needed to be removed. I request to reopen the issue.
@palisadoes There are still some files of this userType Reference. I think we have to remove them, they causing block to progress of my PR too. Though I fixed it , Manik will make a PR as he assigned for this issue.
We have to reopen this issue
Sorry for being inactive. @palisadoes, there is a problem. There are some mutations on which a userRole
directive is imposed. There are some mutations which can only be used by a specific user. Like createAdmin
can only be used by SUPERADMIN
. Now, as userType
is removed, I can't found logic of finding the type of user in userRole
directive. I am thinking of creating of two directives: one for Admin
and other for Superadmin
. I need to consult to that mentor who have worked on directives. Please help!!
Please ask the contributors on the #talawa-projects slack channel. Many of them worked on the userType
migration
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
@Manik2708 Are you still working on this?
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
Unassigning. Inactivity
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
Is your feature request related to a problem? Please describe.
We recently updated the code base to replace the authorization mechanism for users from being a
userType
field in the database’s User collection to anappUserProfile
field.Describe the solution you'd like
userType
in the code base.The aim is for the
userType
to be removed, while maintaining the expected functionality of the appDescribe alternatives you've considered
Approach to be followed (optional)
Additional context
userType
adjustmentPotential internship candidates