Closed palisadoes closed 1 month ago
@palisadoes would like to solve this.
Please write a test to make sure the LAST_RESORT_SUPERADMIN_EMAIL
can always register. This was supposed to have been fixed before, but now it's broken.
These are possibly related issues.
Working on this.
@palisadoes got the exact issue but need some help there is a selectedOrganization argument which the signup api mutation is using which is not being passed from the frontend I would like to know what is the exact use of this argument in this mutation.
From the code it looks like it is making the user join an organization or create a membership request.
but a superAdmin does not require joining any organization, I have to separate the login for superAdmin
@palisadoes Do you mean that whatever the SuperAdmin of last resort selects it doesn't matter we would register him/her as an Admin for all the organizations?
After some thought we should make the LAST_RESORT_SUPERADMIN_EMAIL
user select an organization on registration and we add them to just that organization in adminFor
, but also set isSuperAdmin
.
Is this how we handle an Admin or member being promoted to SuperAdmin currently? Or do we reset adminFor
, but also set isSuperAdmin
?
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
@adi790uu Are you still working on this?
Yeah I was busy so couldn't get to this but will finish this as soon as possible.
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
Unassigning. Inactivity
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.
when I tried to register using the LAST_RESORT_SUPERADMIN_EMAIL email address, a toast notifcation came "wait for admin approval"
is this the issue? (refer to pic)
Closing. It looks like it's been fixed.
Describe the bug
You cannot register using the LAST_RESORT_SUPERADMIN_EMAIL email address
To Reproduce Steps to reproduce the behavior:
develop
codeExpected behavior A clear and concise description of what you expected to happen.
Actual behavior
API Logs
Screenshots
Additional details
This may be related to:
Potential internship candidates