Closed palisadoes closed 4 months ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
Read our CONTRIBUTING.md file. Most importantly:
The recent updates encompass a variety of changes, including dependency upgrades in package.json
, the addition of new GraphQL queries and resolvers, and the introduction of new sorting options. We also see type signature updates in setup.ts
, resolver modifications for agenda sections, and new tests for added functionality. These changes enhance functionality, improve performance, and ensure better organization and testing of the codebase.
Files/Paths | Change Summaries |
---|---|
README.md |
Removed bullet point about visiting a YouTube Channel. |
package.json |
Updated versions of several dependencies and dev dependencies. |
requirements.txt |
Downgraded black from version 24.3.0 to 22.12.0. |
schema.graphql , src/typeDefs/enums.ts , src/typeDefs/queries.ts , src/types/generatedGraphQLTypes.ts |
Added new query agendaItemCategoriesByOrganization and sorting options for UserOrderByInput . |
setup.ts |
Updated type signatures in validate functions and modified default serverPort value. |
src/resolvers/FundraisingCampagin/campaignPledges.ts |
Updated resolver to populate users in campaign pledges query. |
src/resolvers/Mutation/removeAgendaSection.ts , src/resolvers/Mutation/updateAgendaSection.ts |
Updated conditions to check if the user is a creator or superadmin. |
src/resolvers/Organization/posts.ts |
Modified posts resolver to accept a context parameter and transform URLs. |
src/resolvers/Query/agendaItemCategoriesByOrganization.ts , src/resolvers/Query/index.ts |
Introduced and integrated new agendaItemCategoriesByOrganization resolver. |
src/resolvers/index.ts |
Added AgendaItem , AgendaSection , and AgendaCategory to the resolvers object. |
tests/resolvers/FundraisingCampaign/pledge.spec.ts |
Changed query parameter from campaignId to campaigns for fetching pledges. |
tests/resolvers/Organization/posts.spec.ts |
Updated tests to include context object and formatted post data. |
tests/resolvers/Query/agendaItemCategoriesByOrganization.spec.ts |
Added new test suite for agendaItemCategoriesByOrganization resolver. |
In code's vast garden, updates bloom, Dependencies rise, old bugs find doom, New queries sprout, resolvers shine, Sorting options now align. With tests anew, the structure's tight, In this realm, all feels right. 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 90.24390%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 98.50%. Comparing base (
b7d0759
) to head (ea6f898
). Report is 3 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/resolvers/Organization/posts.ts | 73.33% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Updating the main branch to the latest develop code
Summary by CodeRabbit
New Features
agendaItemCategoriesByOrganization
query to fetch categories by organization.Bug Fixes
removeAgendaSection
andupdateAgendaSection
resolvers to properly check user roles.Improvements
posts
resolver to include image and video URL transformations.Dependency Updates
Tests
agendaItemCategoriesByOrganization
resolver.