Closed gautam-divyanshu closed 2 days ago
This change involves enhancing the agendaItemByEvent
query to sort the returned agenda items by their sequence
field in ascending order, ensuring that the results are now consistently ordered.
File | Change Summary |
---|---|
src/resolvers/Query/agendaItemByEvent.ts |
Added sorting to the query by the sequence field |
Objective (Issue #) | Addressed | Explanation |
---|---|---|
Sort agendaItem results by sequence (2369) |
✅ |
In the code's gentle flow, a change now gleams,
Sorting sequences like a river's dreams.
Agenda items in their ordered grace,
Harmonious rhythm finds its proper place.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
Read our CONTRIBUTING.md file. Most importantly:
@palisadoes Please merge this pr
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.51%. Comparing base (
c0468a4
) to head (0fca349
). Report is 593 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@gautam-divyanshu LGTM but one minor concern, what will happen if we provide an invalid relatedEventId, any validation on that?
Update your branch and let me know, will approve and get this PR merged
@gautam-divyanshu LGTM but one minor concern, what will happen if we provide an invalid relatedEventId, any validation on that?
Update your branch and let me know, will approve and get this PR merged
@tasneemkoushar user will not provide relatedEventId; this will be from params, so nothing to be concerned about.
What kind of change does this PR introduce?
Issue Number:
Fixes #2369
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Summary by CodeRabbit
sequence
field.