search

PalisadoesFoundation / talawa-api

API Backend for the Talawa Mobile App. Click on the link below to see our documentation
https://docs.talawa.io/
GNU General Public License v3.0
232 stars 837 forks source link

Fix Deprecated Packages #866

Closed palisadoes closed 1 year ago

palisadoes commented 1 year ago

Describe the bug

Running the npm ci command generates many reports of deprecated packages used by the repo. We need to update the packages for long term maintainability while adjusting the tests and code accordingly.

The best approach may be to make this a parent issue and refer child issues for each deprecated package for people to fix.

To Reproduce Steps to reproduce the behavior:

  1. You can see the nature of the issue by following this link for a recent GitHub Action under install dependencies: https://github.com/PalisadoesFoundation/talawa-api/actions/runs/3941696944/jobs/6746875712

Expected behavior No errors when running the command.

Actual behavior See screenshot below

Screenshots

image

Additional details Create child issues referring to this one as needed.

beingnoble03 commented 1 year ago

@palisadoes Can I create a child issue for removing @types/mongoose-paginate-v2?

beingnoble03 commented 1 year ago

And do we need to create child issue for every deprecated dependency?

palisadoes commented 1 year ago

We can do it all at once.

beingnoble03 commented 1 year ago

@palisadoes fine. Can you please assign me this issue?

beingnoble03 commented 1 year ago

Travelling this week. Will open a PR next week.

beingnoble03 commented 1 year ago

@palisadoes @noman2002 getting a lot of peer dependency conflicts while installing @apollo/server to migrate from apollo-server-express and apollo-server-core as these are deprecated. A solution to this is using --legacy-peer-deps flag when using npm install, this tells npm to ignore all the peer dependency and proceed with the installation anyway. I am not sure if this is safe to use or not. Can you please tell if I should proceed with this or not? Or, Can you suggest what else can be done? I found some answers about the error here .

Also, I think we will need to break this issue into 2 child issues

Because migrating to Apollo Server v4 will require a lot changes.

beingnoble03 commented 1 year ago
Screenshot 2023-01-27 at 6 23 50 PM

Error log

noman2002 commented 1 year ago

@DMills27 @TheHazeEffect @palisadoes Please have a look at it.

palisadoes commented 1 year ago

Closing. We are going to make this a part of the GSoC ideas.