Closed SalilHarit closed 1 year ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests and there are no merge conflicts.
The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
Read our CONTRIBUTING.md file. Most importantly:
Please also make sure all every line item starts with a capitalized letter.
made the requested changes please review
@lonereaper Could you put both superadmin & admin sets of constraints in one file? This will make searching easier, and allow us to use one link to direct users and developers to all of those constraints.
@lonereaper Could you put both superadmin & admin sets of constraints in one file? This will make searching easier, and allow us to use one link to direct users and developers to all of those constraints.
sure thing.
@lonereaper Could you put both superadmin & admin sets of constraints in one file? This will make searching easier, and allow us to use one link to direct users and developers to all of those constraints.
I have made the requested changes kindly review @Cioppolo14.
the admin.md is updated to provide detailed role of admins and the word wrap/copy container is removed also superadmin.md is added to describe superadmin and scope of its role
Issue Number:
Fixes #570
Did you add tests for your changes?
no
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
no
Other information
Have you read the contributing guide?
yes