Closed EshaanAgg closed 1 year ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests and there are no merge conflicts.
The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
Read our CONTRIBUTING.md file. Most importantly:
Can you elaborate on this webserver thing? Locally, I can access them. Clicking schema documentation tab opens the generated pages.
I had updated the sidebars.js
to include a new sidebar.
How can this be content be added under the existing sidebar? There must be a way to do this.
I'm not sure how can we do the same. Currently, all the sidebars and their values are added manually to the file sidebars.js
. But the whole point of using the plugin so that we do not have to generate anything ourselves. Even in the documentation of the plugin, there is no section about integrating it with already existing sidebar (except for the import that I have already done)
I'll read about it a bit more never the less.
I'm not sure how can we do the same. Currently, all the sidebars and their values are added manually to the file
sidebars.js
. But the whole point of using the plugin so that we do not have to generate anything ourselves. Even in the documentation of the plugin, there is no section about integrating it with already existing sidebar (except for the import that I have already done)I'll read about it a bit more never the less.
There must be a way where we can:
docs/schema
. We already have an entry for schemas here which could be replaced:
That way we have a more logical flow.
I have noticed that the automated schema content is not as good as the manually created one which has more context.
Additional questions:
Got it @palisadoes. I would try to work on all of the questions and suggestions you have posted above, and come up with an answer ASAP.
@palisadoes As you can see in this PR, the test-deploy
job is working correctly, as the same doesn't have the latest changes pulled from the talawa automatic documentation updation
. Thus we can safely say that it's not the recently added Talawa API
job that is causing the deployment to fail here in the docs.
You may consider closing this issue as the same in not the cause of the problem as far as I can understand.
@palisadoes
Talawa-API
. You can make it as a project for potential GSoD
candidates to add comments to the typeDefs describing the use of each type. Then the same would be automatically reflected in the documentation here. @palisadoes Can you please review the PR as is? I would fix the conflicts later after your approval, as as soon as I pull changes from the develop
branch, even the test-deploy
job would start to fail for this PR due to the introduction of improperly named files in the recent merges.
Please fix the conflicts
@palisadoes Done.
@EshaanAgg @literalEval How can we fix the GitHub Pages deployment error?
@palisadoes I researched a bit about it and the some ideas refer to adding some sort of numbering or hash to the file name, so that they can never be same as each other. But Dart Doc
doesn't not seem to support this. I have raised an issue regarding this on their repo though.
A temporary fix, as I said before, can be to rename the field from message
to messageStr
maybe will generate files with different names.
@literalEval Wouldn't renaming things require all the hyperlinks to the same automated as well? Does Dart Doc
support the same?
@EshaanAgg that's exactly what I am discussing with the DartDoc
maintainers.
@palisadoes Please review.
Please fix the conflicts
@EshaanAgg The push run failed. Please troubleshoot this
@palisadoes Opened a fixing PR #639
What kind of change does this PR introduce? Feature
Issue Number:
Fixes #629
Did you add tests for your changes? NA
Snapshots/Videos: NA
If relevant, did you update the documentation? NA
Summary Now the schema will be updated for the repository automatically whenever the
schema.json
file is changed from the Talawa API's github action.Does this PR introduce a breaking change? No
Other information NA
Have you read the contributing guide? Yes