search

PalisadoesFoundation / talawa-docs

Documentation for Talawa and Talawa-API
https://docs.talawa.io/
GNU General Public License v3.0
44 stars 146 forks source link

feat(fix): link of the desired features page. #637

Closed SiddheshKukade closed 1 year ago

SiddheshKukade commented 1 year ago

What kind of change does this PR introduce?

Issue Number:

Fixes #636

Did you add tests for your changes? Yes Snapshots/Videos: N/A

If relevant, did you update the documentation? Yes

Summary Fixed the link path

Does this PR introduce a breaking change? No Have you read the contributing guide? Yes

SiddheshKukade commented 1 year ago

@Cioppolo14, the link will work fine now 👍🏻

github-actions[bot] commented 1 year ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests and there are no merge conflicts.

The process helps maintain accurate and well-formatted documentation and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. :dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
palisadoes commented 1 year ago

We need to figure out how to fix the failing tests.

SiddheshKukade commented 1 year ago

@palisadoes, can I take a look to fix that ?

palisadoes commented 1 year ago

You can work with @literalEval on a solution. When that is resolved we can then merge this PR

palisadoes commented 1 year ago

@SiddheshKukade Please merge with the latest upstream and update this PR. The error should be rectified.

Cioppolo14 commented 1 year ago

@SiddheshKukade Is there any update on this?

SiddheshKukade commented 1 year ago

@Cioppolo14, the code is ready to be merged.

SiddheshKukade commented 1 year ago

The CI/CD checks are also passing now 👍🏻