PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
343 stars 467 forks source link

Introduce working of Invite to org option! #1098

Closed ItsAdityaKSingh closed 1 year ago

ItsAdityaKSingh commented 2 years ago

Is your feature request related to a problem? Please describe. The app should be able to utilize the invite option to invite others to our orgs.

Describe the solution you'd like Functioning of Invite button in the profile section.

Describe alternatives you've considered If inviting to orgs is not possible, we could at least help invite people to use talawa app.

Approach to be followed (optional) We can create dynamic links for inviting friends by sharing links and org/app details.

palisadoes commented 2 years ago

@ItsAdityaKSingh We have raised our code coverage percentage to 34%, so you'll need to add tests to this issue for the PRs to be approved.

palisadoes commented 2 years ago

@ItsAdityaKSingh

This will require changes to the API. I think we'll need to split this up into several issues, one for each of the use cases stated above. The first would be to figure out a way to do this where everyone has the privilege.

How do you plan to proceed?

ItsAdityaKSingh commented 2 years ago

Thanks for the insights! It's a really great plan you have laid out here. What I thought about proceeding was to first of all invite external persons to join talawa and be a part of the organization I am sending an invite from. But if you want to proceed with already joined members of talawa, then that would be a nice option too. It could grow gradually with the additional restrictions and features as you mentioned. So, if possible I would like to begin with notifying already joined members about this invite in a notifications section as well as with a general notification from the app.

From this, we could also attach a new feature, that of a notification page with a banner on AppBar leading to it. It can have invites, activities, important dates' notifiers, etc.

image

Your views on this @palisadoes ?

palisadoes commented 2 years ago

What backend do you plan to use to implement the notifications?

ItsAdityaKSingh commented 2 years ago

What backend do you plan to use to implement the notifications?

I could use Firebase Could Messaging to send push notifications to targeted users.

palisadoes commented 2 years ago

We need to make the push functionality account the responsibility of the Talawa end user's organization to reduce the need for us to be called and/or billed for every new organization that signs up.

ItsAdityaKSingh commented 2 years ago

Yes, it requires a firebase account, and Palisadoes Foundation would require to maintain it. I guess the end user's organizations won't handle our APIs or backends so it would be our service. So any better suggestions you would like to put or discuss? I would need to do some research on this.

palisadoes commented 2 years ago

Please research this with the requirements I posted previously. This has been a recurring issue that needs to be addressed. The end user organization needs to have the Firebase account shared between the app and the API, or the push notifications have to be managed solely by the App <-> API connection.

Chat functionality depends on figuring out the right approach to this too.

ItsAdityaKSingh commented 2 years ago

Sure sir, I would try to do the needful along with writing tests for changes I requested in UI in #1097 .

palisadoes commented 2 years ago

@ItsAdityaKSingh please contact @sumitra19jha on Slack before proceeding. He has extensive experience with the backend API will have advice that would be useful. When you have a strategy on how to proceed we can continue the discussion here.

ItsAdityaKSingh commented 2 years ago

Thanks a lot! I would be glad to learn from him and try to implement this feature :)

github-actions[bot] commented 2 years ago

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.