search

PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 435 forks source link

edited splash_screen_test #2376

Closed Sandesh-03 closed 4 months ago

Sandesh-03 commented 4 months ago

What kind of change does this PR introduce?

Unit Test

Issue Number:

Fixes https://github.com/PalisadoesFoundation/talawa/issues/2145

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

I have solved the issues that were mentioned.

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

github-actions[bot] commented 4 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Cioppolo14 commented 4 months ago

@Sandesh-03 Please fix the failing tests.

Cioppolo14 commented 4 months ago

@Sandesh-03 Are you working on this?

Sandesh-03 commented 4 months ago

@Cioppolo14 yes

Cioppolo14 commented 4 months ago

@Sandesh-03 Please tell me when this PR will be ready.

Azad99-9 commented 4 months ago

@Sandesh-03 are you facing any issue, need any help?

Sandesh-03 commented 4 months ago

@Sandesh-03 are you facing any issue, need any help?

Yeh. The test is running fine on my pc I have also tried the command which failed during review, can you help me with this?

Azad99-9 commented 4 months ago

The reason for failing tests is, your code is not properly formatted.

use this procedure before raising any PR to talawa:

  1. rundart analyze, fix all the issues that will be shown there.
  2. rundart format ..
  3. run flutter test --coverage, fix any failing tests.
Sandesh-03 commented 4 months ago

@Azad99-9 Thanks for your help.