PalisadoesFoundation / talawa

Community Organization Management Software. Click on the link below to see our documentation.
https://docs.talawa.io/
GNU General Public License v3.0
306 stars 435 forks source link

Built User Interface for creating recurring events. #2386

Closed Azad99-9 closed 4 months ago

Azad99-9 commented 4 months ago

What kind of change does this PR introduce?

This PR introduces the essential User Interface for Creating Recurring Events.

Issue Number:

Fixes #2341

Did you add tests for your changes?

yes

Snapshots/Videos:

video link.

If relevant, did you update the documentation?

Summary

Note: Api integration is not yet done. As significant number of lines of code were added, for manageable reviewing purpose the api integration part will be included in a subsequent PR.

Does this PR introduce a breaking change?

No.

Other information

Have you read the contributing guide?

Yes.

github-actions[bot] commented 4 months ago

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

codecov[bot] commented 4 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eb333ad) 95.56% compared to head (3944358) 95.67%. Report is 5 commits behind head on develop.

Files Patch % Lines
...s/event_view_models/event_calendar_view_model.dart 96.29% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2386 +/- ## =========================================== + Coverage 95.56% 95.67% +0.11% =========================================== Files 147 152 +5 Lines 7187 7393 +206 =========================================== + Hits 6868 7073 +205 - Misses 319 320 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cioppolo14 commented 4 months ago

@Ayush0Chaudhary @literalEval Can you review this PR?

noman2002 commented 4 months ago

@Azad99-9 Please attach a video of it.

Azad99-9 commented 4 months ago

@noman2002 please have a look I have attached the video.

https://github.com/PalisadoesFoundation/talawa/assets/120930148/389aeb12-18e4-4bde-8616-c79eebffbdcb

Azad99-9 commented 4 months ago

https://github.com/PalisadoesFoundation/talawa/assets/120930148/c6c2f647-9030-485d-9f83-2c88a814aab4

@noman2002 please suggest is it ok now. If ok, I will push it's code.

noman2002 commented 4 months ago

1000151545.mp4

@noman2002 please suggest is it ok now. If ok, I will push it's code.

Looks better now.