Closed Azad99-9 closed 4 months ago
We have these basic policies to make the approval process smoother for our volunteer team.
Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.
Do not assign reviewers. Our Queue Monitors will review your PR and assign them. When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Your reviewer(s) will have the following roles:
:dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
eb333ad
) 95.56% compared to head (3944358
) 95.67%. Report is 5 commits behind head on develop.
Files | Patch % | Lines |
---|---|---|
...s/event_view_models/event_calendar_view_model.dart | 96.29% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Ayush0Chaudhary @literalEval Can you review this PR?
@Azad99-9 Please attach a video of it.
@noman2002 please have a look I have attached the video.
https://github.com/PalisadoesFoundation/talawa/assets/120930148/389aeb12-18e4-4bde-8616-c79eebffbdcb
https://github.com/PalisadoesFoundation/talawa/assets/120930148/c6c2f647-9030-485d-9f83-2c88a814aab4
@noman2002 please suggest is it ok now. If ok, I will push it's code.
1000151545.mp4
@noman2002 please suggest is it ok now. If ok, I will push it's code.
Looks better now.
What kind of change does this PR introduce?
This PR introduces the essential User Interface for
Creating Recurring Events
.Issue Number:
Fixes #2341
Did you add tests for your changes?
yes
Snapshots/Videos:
video link.
If relevant, did you update the documentation?
Summary
popupmenubutton
to switch views in EventCalendar. views [day, month, schedule].create event page.
CustomRecurrencePage
to define user desired recurrence configuration.Note:
Api
integration is not yet done. As significant number of lines of code were added, for manageable reviewing purpose the api integration part will be included in a subsequent PR.Does this PR introduce a breaking change?
No.
Other information
Have you read the contributing guide?
Yes.